Skip to content

Conversation

me-it-is
Copy link
Contributor

@me-it-is me-it-is commented Sep 8, 2025

when constructing WebAssembly.Memory if initial is greater than maximum a range error will be thrown.

fixes
https://wpt.fyi/results/wasm/jsapi/memory/constructor.any.worker.html?product=ladybird Initial value exceeds maximum

@me-it-is me-it-is requested a review from alimpfard as a code owner September 8, 2025 00:57
@me-it-is me-it-is force-pushed the fix-construct-out-of-range branch from 90378aa to 5873129 Compare September 8, 2025 01:04
@me-it-is
Copy link
Contributor Author

me-it-is commented Sep 8, 2025

It seems like the sanitizers failing is unrelated to this pr.

Copy link
Contributor

@alimpfard alimpfard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jelle already commented the one useful thing I intended to say, so here's the nitpick:

@me-it-is me-it-is force-pushed the fix-construct-out-of-range branch from 5873129 to 45976aa Compare September 10, 2025 01:11
When constructing WebAssembly.Memory if initial is greater than maximum
a range error will be thrown.

Fixes "Initial value exceeds maximum" in
https://wpt.fyi/results/wasm/jsapi/memory/constructor.any.worker.html?product=ladybird
@me-it-is me-it-is force-pushed the fix-construct-out-of-range branch from 45976aa to 232a37e Compare September 10, 2025 01:14
@alimpfard
Copy link
Contributor

Thank you!

@alimpfard alimpfard enabled auto-merge (rebase) September 10, 2025 03:17
@alimpfard alimpfard merged commit 62fe795 into LadybirdBrowser:master Sep 10, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants